lkml.org 
[lkml]   [2013]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH V2] Regulator: Reorder the min max assignment in the sequence of regulator_set_voltage function
Date
Hi Mark,

> -----Original Message-----
> From: Mark Brown [mailto:broonie@opensource.wolfsonmicro.com]
> Sent: Monday, February 11, 2013 10:35 PM
> To: J, KEERTHY
> Cc: linux-kernel@vger.kernel.org; lgirdwood@gmail.com
> Subject: Re: [PATCH V2] Regulator: Reorder the min max assignment in
> the sequence of regulator_set_voltage function
>
> On Mon, Feb 11, 2013 at 12:19:34PM +0530, J Keerthy wrote:
>
> > The min and max values for regulators are getting assigned before
> > actually the voltage is set. So making sure that min and max values
> > are assigned only if the voltage is successfully set else keeping the
> > last successfully set voltage's min and max values.
>
> > This is boot tested on OMAP4430 and OMAP4460 boards.
>
> This seems fine but doesn't apply against topic/core or -next, can you
> please regenerate against topic/core and resend?

I pulled the topic/core on to my tree. Seems like the exact fix has
Already been made in that branch :-P.

commit 92d7a55879c01b30349045501108e775655a4b92
Author: Paolo Pisati <paolo.pisati@canonical.com>
Date: Thu Dec 13 10:13:00 2012 +0100

regulator: core: if voltage scaling fails, restore original voltage values

It is already taken care.
>
> > V2: Fixed comment from Mark. Introduced local variables to hold
> > current min and max values.
>
> Don't include things like this in the changelog, include them after the
> --- as covered in SubmittingPatches.

Ok

Thanks,
Keerthy


\
 
 \ /
  Last update: 2013-02-12 13:01    [W:0.048 / U:0.552 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site