[lkml]   [2013]   [Feb]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [patch v4 01/18] sched: set SD_PREFER_SIBLING on MC domain to reduce a domain level
On Thu, 2013-01-24 at 11:06 +0800, Alex Shi wrote:
> The domain flag SD_PREFER_SIBLING was set both on MC and CPU domain at
> frist commit b5d978e0c7e79a, and was removed uncarefully when clear up
> obsolete power scheduler. Then commit 6956dc568 recover the flag on CPU
> domain only. It works, but it introduces a extra domain level since this
> cause MC/CPU different.
> So, recover the the flag in MC domain too to remove a domain level in
> x86 platform.

This fails to clearly state why its desirable.. I'm guessing its because
we should use sibling cache domains before sibling threads, right?

A clearly stated reason is always preferable over: it was this way, make
it so again; which leaves us wondering why.

 \ /
  Last update: 2013-02-12 12:21    [W:0.416 / U:0.404 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site