lkml.org 
[lkml]   [2013]   [Feb]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: query about create_mnt_ns
From
Thanks :)

On Mon, Feb 11, 2013 at 7:40 PM, Al Viro <viro@zeniv.linux.org.uk> wrote:
> On Mon, Feb 11, 2013 at 05:44:29PM +0530, Rajat Sharma wrote:
>> Hi,
>>
>> I was looking at implementation of init_mount_tree() function and
>> found a discrepancy in list manipulation of mnt_namsespace and
>> vfsmount across kernel version 2.6.30. Up till kernel version
>> 2.6.30.x, vfsmount structure was added to the list headed by
>> mnt_namespace structure just allocated:
>>
>> list_add(&mnt->mnt_list, &ns->list);
>>
>> Beyond that with the introduction of function create_mnt_ns(), it does
>> reverse of previous behavior:
>>
>> list_add(&new_ns->list, &mnt->mnt_list);
>>
>> i.e. it is adding new mnt_namespace to the vfsmount list. Is this the
>> expected behavior? i.e. do we want to maintain list of namespaces per
>> mount? Please let me know if I am missing something here.
>
> The fact that if A and B are both empty, list_add(A, B) and list_add(B, A)
> will do exactly the same thing ;-)


\
 
 \ /
  Last update: 2013-02-11 16:41    [W:0.475 / U:0.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site