Messages in this thread | | | Date | Mon, 11 Feb 2013 13:28:38 +0900 | From | Alex Courbot <> | Subject | Re: [PATCH] gpiolib: Fix locking on gpio debugfs files |
| |
On 02/09/2013 07:34 PM, Grant Likely wrote: > The debugfs files really need to hold the gpiolib spinlock before > accessing the list. Otherwise chip addition/removal will cause an oops. > > Cc: Alexandre Courbot <acourbot@nvidia.com> > Cc: Linus Walleij <linus.walleij@linaro.org> > Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
Tested-by: Alexandre Courbot <acourbot@nvidia.com>
Just wondering: if we manage to change this spinlock into a mutex in the future, wouldn't it be better to acquire it only once in gpiolib_seq_start() and release it in gpiolib_seq_stop()?
Even though the protection introduced by this patch definitely improves the situation, it seems to me that chips could still be removed while being displayed by gpiolib_seq_show().
Thanks, Alex.
| |