lkml.org 
[lkml]   [2013]   [Feb]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v5 05/45] percpu_rwlock: Make percpu-rwlocks IRQ-safe, optimally
    On 02/11/2013 12:12 AM, Oleg Nesterov wrote:
    > only one cosmetic nit...
    >
    > On 01/22, Srivatsa S. Bhat wrote:
    >>
    >> +#define READER_PRESENT (1UL << 16)
    >> +#define READER_REFCNT_MASK (READER_PRESENT - 1)
    >> +
    >> #define reader_uses_percpu_refcnt(pcpu_rwlock, cpu) \
    >> (ACCESS_ONCE(per_cpu(*((pcpu_rwlock)->reader_refcnt), cpu)))
    >>
    >> #define reader_nested_percpu(pcpu_rwlock) \
    >> - (__this_cpu_read(*((pcpu_rwlock)->reader_refcnt)) > 1)
    >> + (__this_cpu_read(*((pcpu_rwlock)->reader_refcnt)) & READER_REFCNT_MASK)
    >>
    >> #define writer_active(pcpu_rwlock) \
    >> (__this_cpu_read(*((pcpu_rwlock)->writer_signal)))
    >
    > I think this all can go to lib/percpu-rwlock.c. Nobody needs to know
    > these implementation details.
    >

    Ok, will move them.

    Regards,
    Srivatsa S. Bhat



    \
     
     \ /
      Last update: 2013-02-10 21:21    [W:4.225 / U:0.284 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site