Messages in this thread | | | From | Mark Einon <> | Date | Fri, 1 Feb 2013 23:00:14 +0000 | Subject | Re: [PATCH] firewire: Fix ohci free_irq() warning |
| |
On 1 February 2013 21:09, Peter Hurley <peter@hurleysoftware.com> wrote: > Hi Mark, > > I think what Alan means is that the suspend/resume code should just > mask/unmask interrupts at the OHCI controller, via the OHCI > IntEventClear/Set registers (naturally, saving the current mask and > restoring it on resume). > > Of course, there's a lot more to do with an OHCI controller -- as you > note. Like stopping running DMA contexts :) And restarting them on > resume. > > I'd do it, but I'm buried to my eyeballs in tty right now -- not fun. I > can _eventually_ do this as I need to address problems with the FW643 > anyway at some point, but it's going to be a little while.
Hi Peter,
Ok, understood. I can certainly attempt a patch if I get time.
> > In the meantime, I'm a little confused: you say you can't test this code > because you have no hardware; but then how'd you trip this bug?
I can test the code in that I have a firewire port on my laptop, but haven't got anything to plug into the port. I assume that any large changes I make are quite capable of breaking something there...
Cheers,
Mark
| |