lkml.org 
[lkml]   [2013]   [Feb]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/7] liblock: public headers for mutex implementation

* Sasha Levin <sasha.levin@oracle.com> wrote:

> These headers provide the same API as their pthread mutex counterparts.
>
> The design here is to allow to easily switch to liblock lock validation
> just by adding a "liblock_" to pthread_mutex_*() calls, which means that
> it's easy to integrate liblock into existing codebases.

I'd suggest to name the user-space counterpart 'liblockdep', to
make it clear that this is user-space lockdep.

Regarding pthread_mutex_t checking, I think what we *really*
want is a wrapper that can be activated via:

#define __USE_LIBLOCKDEP

And which then takes over the pthread primitives via:

#define pthread_mutex_lock liblockdep_pthread_mutex_lock

or so.

That way the source code only needs a __USE_LIBLOCKDEP in one or
two key places and checking is activated.

Thanks,

Ingo


\
 
 \ /
  Last update: 2013-02-01 11:43    [W:0.093 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site