lkml.org 
[lkml]   [2013]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v5 01/14] x86/mm: sparse warning fix for early_memremap
    On 12/09/13 at 04:05pm, Borislav Petkov wrote:
    > On Mon, Dec 09, 2013 at 05:42:14PM +0800, Dave Young wrote:
    > > There's a lot of sparse warnings for code like below:
    > > void *a = early_memremap(phys_addr, size);
    > >
    > > early_memremap intend to map kernel memory with ioremap facility, the return
    > > pointer should be a kernel ram pointer instead of iomem one.
    > >
    > > For making the function clearer and supressing sparse warnings this patch
    > > do below two things:
    > > 1. cast to (__force void *) for the return value of early_memremap
    >
    > I'd guess this is to shut up the __iomem thing? And we're getting that
    > because we're using ioremap, ... hohum...

    Yes, IMHO early_memremap really should not return __iomem pointer since it's
    *memremap*...

    Thanks
    Dave


    \
     
     \ /
      Last update: 2013-12-10 03:41    [W:3.229 / U:0.456 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site