lkml.org 
[lkml]   [2013]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 0/9] ARM: Initial support for Marvell Berlin SoCs
Hi,

On Sun, Dec 08, 2013 at 03:13:57PM +0100, Sebastian Hesselbarth wrote:
> Hopefully last round of initial support patches for Marvell Berlin SoCs
> before I can send the final PR for v3.14.
>
> Compared to last version sent, this patch set has now a Reviewed-by from
> Thomas Gleixner for the irqchip driver (Thanks for that!). Also, l2x0
> compatibles can now be reordered alphabetically instead of by derivate
> thanks to [1].
>
> Marvell Docs have been updated to not mention Armada 1000 which has been
> discontinued by Marvell and vanished from their website. The dtsi/dts file
> have been renamed to vendor,name.dts[i], which is the preferred new naming
> scheme.
>
> Open issues are the never ending dw_apb_timers_of story, which I ignore
> for now and hope they get in someday. Also, TWD SMP dependency and
> early l2x0_of_init will be addressed at a later date. At the current
> feature set of Berlin SoC, I don't see why the above issues should further
> stall this patches.
>
> I guess, all patches can go through ARM SoC tree, except Tauros3 patch
> which I should submit to Russell's patch tracker?

Yep, sounds good.

I took a cursory glance at the patchset and it looks sane to me. I didn't
review in detail though.

One open question: Why don't you just add this to mach-mvebu? I thought
all modern Marvell platforms were going to converge on that eventually
anyway, and it's easy to add it now that it's early and simple..

Also, see below:

> Sebastian Hesselbarth (9):
> irqchip: add DesignWare APB ICTL interrupt controller
> MAINTAINERS: add ARM Marvell Berlin SoC
> ARM: l2x0: add Marvell Tauros3 support
> ARM: add Marvell Berlin SoC familiy to Marvell doc
> ARM: add Marvell Berlin SoCs to multi_v7_defconfig
> ARM: add Marvell Berlin UART0 lowlevel debug
> ARM: add Armada 1500 and Sony NSZ-GS7 device tree files
> ARM: add Armada 1500-mini and Chromecast device tree files
> ARM: add initial support for Marvell Berlin SoCs
>
> Documentation/arm/Marvell/README | 24 +++
> Documentation/devicetree/bindings/arm/l2cc.txt | 23 ++-
> .../devicetree/bindings/arm/marvell,berlin.txt | 24 +++
> .../interrupt-controller/snps,dw-apb-ictl.txt | 32 +++
> MAINTAINERS | 6 +
> arch/arm/Kconfig | 2 +
> arch/arm/Kconfig.debug | 10 +
> arch/arm/Makefile | 1 +
> arch/arm/boot/dts/Makefile | 3 +
> arch/arm/boot/dts/google,chromecast.dts | 29 +++
> arch/arm/boot/dts/marvell,berlin2.dtsi | 227 +++++++++++++++++++++
> arch/arm/boot/dts/marvell,berlin2cd.dtsi | 210 +++++++++++++++++++
> arch/arm/boot/dts/sony,nsz-gs7.dts | 29 +++

We have had a long-standing standard of naming the dts files
<family>-<board>.dts (or <soc_vendor>-<board>.dts). Let's continue
sticking to that since it helps keep the namespace somewhat segmented per
platform in arch/arm/boot/dts.


-Olof


\
 
 \ /
  Last update: 2013-12-10 03:01    [W:0.934 / U:0.492 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site