Messages in this thread | | | Date | Mon, 09 Dec 2013 12:42:59 -0700 | From | David Ahern <> | Subject | Re: [PATCH] perf tools: Fix bug for perf kvm report without guestmount. |
| |
On 12/9/13, 11:49 AM, Arnaldo Carvalho de Melo wrote: > Em Mon, Dec 09, 2013 at 11:08:05AM -0700, David Ahern escreveu: >> On 12/9/13, 11:07 AM, Arnaldo Carvalho de Melo wrote: >>> Em Sun, Dec 08, 2013 at 10:39:36AM -0700, David Ahern escreveu: >>>> On 12/6/13, 4:56 AM, Arnaldo Carvalho de Melo wrote: >>>>> You get correct results because the modules/kallsyms info you provided >>>>> matches the VM you're testing, i.e. the pid test is not needed. >>>>> >>>>> I think we need to specify for which PID the --guestmodules and >>>>> --guestkallsyms is provided, so that it can refuse to use it for pids >>>>> where it is invalid. >>>> >>>> Those are arguments are shortcut defaults for guests. If the VMs are >>>> not running the same kernel use guestmount and pid specific >>>> directories. e.g., >>>> >>>> /tmp/guestmount/<pid>/proc/kallsyms >>> >>> Does this already works like that? /me tries to figure that out... >> >> yes. >> > > Yeah, I saw that: > > if ((pid != HOST_KERNEL_ID) && > (pid != DEFAULT_GUEST_KERNEL_ID) && > (symbol_conf.guestmount)) { > sprintf(path, "%s/%d", symbol_conf.guestmount, pid); > > So, in summary, ack/nack this patch? >
NACK. Not needed and breaks the very intent of those 2 options.
David
| |