lkml.org 
[lkml]   [2013]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] binfmt_elf: fix PIE load with randomization disabled
From
On Mon, Dec 9, 2013 at 12:57 PM, Jiri Kosina <jkosina@suse.cz> wrote:
> On Mon, 9 Dec 2013, H.J. Lu wrote:
>
>> Normally, a PIE executable has zero virtual address on the first PT_LOAD
>> segment and kernel will load such executable at random address when
>> randomization is enabled. If randomization is disabled, kernel will load
>> it at a fixed address. But if a PIE executable has non-zero virtual
>> address on the first PT_LOAD segment, kernel will load such executable
>> at the non-zero virtual address when randomization is enabled. But when
>> randomization is disabled, kernel ignores the non-zero virtual address
>> at the non-zero virtual address when randomization is enabled.
>
> Hmm ... isn't actually this the thing that needs to be fixed instead?
>
> IOW, when randomization is enabled, is there a reason not to load on
> randomized address? (even if the first PT_LOAD segment has non-zero
> vaddr?)

No, please don't do that. Normally, PIE has zero load address and kernel
can load it anywhere. There are multiple reasons why PIE has non-zero
load address. Saying you need to load a program above 4GB under x86-64,
you can't do that with normal dynamic executable. PIE with non-zero load
address is the only way to do that on x86-64.

>> But when randomization is disabled, kernel ignores the non-zero virtual
>> address on the first PT_LOAD segment and loads it at the fixed address.
>> This patch makes kernel consistent by loading PIE executable with
>> non-zero virtual address at the non-zero virtual address, regardless if
>> randomization is enabled or disabled.
>


--
H.J.


\
 
 \ /
  Last update: 2013-12-09 22:21    [W:0.197 / U:0.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site