lkml.org 
[lkml]   [2013]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 2/2] PCI: Only enable realloc auto when root bus has 64bit mmio
On Mon, Dec 9, 2013 at 1:10 PM, Yinghai Lu <yinghai@kernel.org> wrote:
> On Mon, Dec 9, 2013 at 11:42 AM, Bjorn Helgaas <bhelgaas@google.com> wrote:
>> That doesn't answer my question at all.
>>
>> I understand that this change makes it so Joseph doesn't have to use
>> "pci=realloc=off". But why should auto-reallocation be limited to
>> buses that have resources above 4GB? That doesn't make any sense.
>>
>> We should fix the reallocation code so it can deal with this case. If
>> there's not enough space for everything, obviously we have to leave
>> something unassigned. A ROM BAR is a good candidate for leaving
>> unassigned, because most of the time we can get along without it.
>
> Yes, that is ideal and not that simple.
> but that would be hard to backport to old kernels.

Yes, I agree. I didn't say it would be simple. The quick fix would
be easy for now, but adding nonsensical code makes our lives harder
long into the future.

Bjorn


\
 
 \ /
  Last update: 2013-12-09 21:41    [W:0.162 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site