lkml.org 
[lkml]   [2013]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] gadget: make USB_CONFIGFS_MASS_STORAGE depend on BLOCK
    On Mon, Dec 09, 2013 at 11:27:31AM -0800, Randy Dunlap wrote:
    > On 12/09/13 11:21, Felipe Balbi wrote:
    > > On Mon, Dec 09, 2013 at 11:18:25AM -0800, Randy Dunlap wrote:
    > >> From: Randy Dunlap <rdunlap@infradead.org>
    > >>
    > >> Make USB_CONFIGFS_MASS_STORAGE depend on BLOCK just like the other
    > >> gadget MASS_STORAGE options do. This fixes the following build errors
    > >> that occur when BLOCK is not enabled:
    > >>
    > >> drivers/usb/gadget/storage_common.c: In function 'fsg_lun_open':
    > >> drivers/usb/gadget/storage_common.c:241:3: error: implicit declaration of function 'bdev_logical_block_size' [-Werror=implicit-function-declaration]
    > >> drivers/usb/gadget/storage_common.c:242:3: error: implicit declaration of function 'blksize_bits' [-Werror=implicit-function-declaration]
    > >>
    > >> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
    > >> Cc: Andrzej Pietrasiewicz <andrzej.p@samsung.com>
    > >> Cc: Felipe Balbi <balbi@ti.com>
    > >
    > > Already have a patch for that
    >
    > Thanks.
    >
    > It wouldn't hurt to fix mainline so that it builds without this error, eh?

    I'm not the one who merges patches in Linus' tree, that's only up to
    Linus eh ?

    That patch is already in Greg's branch and he has already sent a pull
    request to Linus.

    If you're concerned it takes too long to fix build errors, you can ping
    Linus to see if he'll merge Greg's pull request sooner. There's nothing
    I can do.

    --
    balbi
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2013-12-09 21:21    [W:3.373 / U:0.604 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site