Messages in this thread | | | Date | Mon, 09 Dec 2013 11:27:38 -0700 | From | Stephen Warren <> | Subject | Re: [PATCH V2 2/2] pinctrl: tegra: add pinmux controller driver for Tegra124 |
| |
On 12/09/2013 03:32 AM, Laxman Dewangan wrote: > From: Ashwini Ghuge <aghuge@nvidia.com> > > This adds a driver for the Tegra124 pinmux, and required > parameterization data for Tegra124. > > The driver uses the common Tegra pincontrol driver utility > functions to implement the majority of the driver. > > This driver is not compatible with the earlier NVIDIA's SoCs, > hence add new compatibile as "nvidia,tegra124-pinmux". > > Originally written by Ashwini Gguhe. > Thierry: > - Cleanups in patches. > ldewangan: > - Fix some entries for groups. > - Fix MUX enums and group sequence.
> +static const struct pinctrl_pin_desc tegra124_pins[] = {
Still two spaces there...
BTW, I said the following before for both patches; please make sure you add this to the commit description...
Acked-by: Stephen Warren <swarren@nvidia.com>
Even if I didn't say it before, it's certainly now,
Tested-by: Stephen Warren <swarren@nvidia.com>
(I also tested your patches that add the pinctrl DT entries to the Venice2 DT file. Thanks.)
| |