lkml.org 
[lkml]   [2013]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH -next] x86, kaslr: remove unused including <linux/version.h>
From
On Sat, Dec 7, 2013 at 5:02 AM, Wei Yongjun <weiyj.lk@gmail.com> wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Remove including <linux/version.h> that don't need it.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

Thanks, yeah, ultimately utsrelease.h had everything that was needed.

Acked-by: Kees Cook <keescook@chromium.org>

> ---
> arch/x86/boot/compressed/aslr.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/boot/compressed/aslr.c b/arch/x86/boot/compressed/aslr.c
> index 84be175..90a21f4 100644
> --- a/arch/x86/boot/compressed/aslr.c
> +++ b/arch/x86/boot/compressed/aslr.c
> @@ -10,7 +10,6 @@
> #include <linux/uts.h>
> #include <linux/utsname.h>
> #include <generated/utsrelease.h>
> -#include <linux/version.h>
>
> /* Simplified build-specific string for starting entropy. */
> static const char build_str[] = UTS_RELEASE " (" LINUX_COMPILE_BY "@"
>

-Kees

--
Kees Cook
Chrome OS Security


\
 
 \ /
  Last update: 2013-12-09 19:41    [W:0.073 / U:2.652 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site