Messages in this thread | | | Date | Mon, 9 Dec 2013 11:24:49 -0500 | From | Steven Rostedt <> | Subject | Re: [PATCHSET 00/14] tools lib traceevent: Get rid of *die() calls from parse-filter.c |
| |
On Mon, 9 Dec 2013 14:33:57 +0900 Namhyung Kim <namhyung@kernel.org> wrote:
> Hello, > > This patchset tries to remove all die() calls in event filter parsing > code. The only remaining bits are in trace-seq.c which implement > print functions and I want to hear what's the best way we can handle > the error case during the print. > > I also put this patches on libtraceevent/die-removal-v1 branch in my tree > > git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git > > > Any comments are welcome, thanks > Namhyung >
Other than what I commented on, the rest can have my:
Reviewed-by: Steven Rostedt <rostedt@goodmis.org>
-- Steve
> > Namhyung Kim (14): > tools lib traceevent: Get rid of malloc_or_die() in show_error() > tools lib traceevent: Get rid of die in add_filter_type() > tools lib traceevent: Get rid of malloc_or_die() in > pevent_filter_alloc() > tools lib traceevent: Get rid of malloc_or_die() allocate_arg() > tools lib traceevent: Get rid of malloc_or_die() in read_token() > tools lib traceevent: Get rid of malloc_or_die() in find_event() > tools lib traceevent: Get rid of malloc_or_die() in add_event() > tools lib traceevent: Get rid of die() in create_arg_item() > tools lib traceevent: Get rid of die() in add_right() > tools lib traceevent: Get rid of die() in reparent_op_arg() > tools lib traceevent: Get rid of malloc_or_die() in > pevent_filter_add_filter_str() > tools lib traceevent: Get rid of die() in > pevent_filter_clear_trivial() > tools lib traceevent: Refactor test_filter() to get rid of die() > tools lib traceevent: Get rid of die() in some string conversion > funcitons > > tools/lib/traceevent/event-parse.h | 3 +- > tools/lib/traceevent/parse-filter.c | 432 +++++++++++++++++++++++++----------- > 2 files changed, 303 insertions(+), 132 deletions(-) >
| |