Messages in this thread | | | From | Kevin Hilman <> | Subject | Re: [RFC/RFT/PATCH V3] gpio: omap: refresh patch "be more aggressive with pm_runtime" against v3.12-rc5 | Date | Mon, 09 Dec 2013 08:03:21 -0800 |
| |
Chao Xu <caesarxuchao@gmail.com> writes:
> From: Felipe Balbi <balbi@ti.com> > > try to keep gpio block suspended as much as possible.
> Tested with pandaboard and a sysfs exported gpio. > > Signed-off-by: Felipe Balbi <balbi at ti.com> > > [caesarxuchao@gmail.com : Refreshed against v3.12-rc5, and added > revision check to enable aggressive pm_runtime on OMAP4-only. Because > am33xx_gpio_sysc.idlemodes seems to be wrongly marked as > SIDLE_SMART_WKUP, which might cause missed interrupts with this patch. > Tested on Pandaboard rev A2.] > Signed-off-by: Chao Xu <caesarxuchao@gmail.com>
I have several problems with this patch.
First, the changelog is missing a lot of information. In particular, nowhere is it described what problem is this patch addressing and how this patch addresses that problem.
Second, I don't see any mention of off-mode, and I suspect there are issues with off-mode here that are not being addressed.
Also, I *really* don't like any approach that is targetted at a single SoC.
Kevin
| |