Messages in this thread |  | | Date | Tue, 10 Dec 2013 00:11:45 +0900 | From | Masami Hiramatsu <> | Subject | Re: [PATCH 13/17] tracing/uprobes: Pass 'is_return' to traceprobe_parse_probe_arg() |
| |
(2013/12/09 15:20), Namhyung Kim wrote: > From: Namhyung Kim <namhyung.kim@lge.com> > > Currently uprobes don't pass is_return to the argument parser so that > it cannot make use of "$retval" fetch method since it only works for > return probes.
Looks good for me.
Reviewed-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
> > Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> > Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com> > Cc: Oleg Nesterov <oleg@redhat.com> > Cc: zhangwei(Jovi) <jovi.zhangwei@huawei.com> > Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net> > Signed-off-by: Namhyung Kim <namhyung@kernel.org> > --- > kernel/trace/trace_uprobe.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c > index 89dd346865ad..d407a556aa55 100644 > --- a/kernel/trace/trace_uprobe.c > +++ b/kernel/trace/trace_uprobe.c > @@ -512,7 +512,7 @@ static int create_trace_uprobe(int argc, char **argv) > > /* Parse fetch argument */ > ret = traceprobe_parse_probe_arg(arg, &tu->tp.size, parg, > - false, false); > + is_return, false); > if (ret) { > pr_info("Parse error at argument[%d]. (%d)\n", i, ret); > goto error; >
-- Masami HIRAMATSU IT Management Research Dept. Linux Technology Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu.pt@hitachi.com
|  |