lkml.org 
[lkml]   [2013]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH v2] dma: fix vchan_cookie_complete() debug print
Date
vchan_cookie_complete() is supposed to print the cookie value
but it's always zero because:

dma_cookie_complete() is called prior to dev_vdbg()

Move the call, place it after dev_vdbg().

Signed-off-by: Jonas Jensen <jonas.jensen@gmail.com>
---

Notes:
Changes since v1:

1. remove local dma_cookie_t
2. call dma_cookie_complete() after dev_vdbg()

Applies to next-20131209

drivers/dma/virt-dma.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/virt-dma.h b/drivers/dma/virt-dma.h
index 85c19d6..7d6f611 100644
--- a/drivers/dma/virt-dma.h
+++ b/drivers/dma/virt-dma.h
@@ -85,9 +85,9 @@ static inline void vchan_cookie_complete(struct virt_dma_desc *vd)
{
struct virt_dma_chan *vc = to_virt_chan(vd->tx.chan);

- dma_cookie_complete(&vd->tx);
dev_vdbg(vc->chan.device->dev, "txd %p[%x]: marked complete\n",
vd, vd->tx.cookie);
+ dma_cookie_complete(&vd->tx);
list_add_tail(&vd->node, &vc->desc_completed);

tasklet_schedule(&vc->task);
--
1.8.2.1


\
 
 \ /
  Last update: 2013-12-09 10:41    [W:0.094 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site