Messages in this thread |  | | Date | Sun, 8 Dec 2013 22:46:54 -0800 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH] devtmpfs: Calling delete_path() only when necessary |
| |
On Wed, Dec 04, 2013 at 02:44:14PM +0800, Axel Lin wrote: > 2013/12/4 Rob Landley <rob@landley.net>: > > On 11/16/2013 02:15:23 AM, Axel Lin wrote: > >> > >> The deleted variable is always 1 in current code. > >> Initialize deleted variable to be 0, so delete_path() will be called only > >> when > >> necessary. > >> > >> Signed-off-by: Axel Lin <axel.lin@ingics.com> > > > > > > I'm not seeing this in linux-next, or a reply on the web archive. Assuming > > nobody's objected to this, you might want to forward it to > > trivial@kernel.org. > > > > That said, you could describe what it _does_ a little more? > > I was expecting Greg to pick up this patch. > > I thought the description is pretty clear. > What the patch does is changing the init value of deleted variable to 0. > The intention of this change is to avoid unnecessary delete_path() call.
I agree the logic is a bit odd here, but are you seeing an "unnecessary" delete_path() call happening? The code has always been like this from what I can tell...
thanks,
greg k-h
|  |