Messages in this thread | | | Date | Mon, 9 Dec 2013 16:41:14 +0800 | From | bilhuang <> | Subject | Re: [PATCH v3 1/2] cpufreq: tegra: Call tegra_cpufreq_init() specifically in machine code |
| |
On 12/06/2013 06:54 AM, Stephen Warren wrote: > On 12/05/2013 12:44 AM, Bill Huang wrote: >> Move the call from module_init to Tegra machine codes so it won't be >> called in a multi-platform kernel running on non-Tegra SoCs. > >> diff --git a/include/linux/tegra-soc.h b/include/linux/tegra-soc.h > > It might be better to create <linux/tegra-cpufreq.h> for the interface > to the cpufreq driver; tegra-soc.h is for the interface to core Tegra > code *from* other drivers. Thanks, will do. > >> +#ifdef CONFIG_ARM_TEGRA_CPUFREQ >> +int tegra_cpufreq_init(void); >> +#else >> +static inline int tegra_cpufreq_init(void) >> +{ >> + return -EINVAL; >> +} >> +#endif > > Probably best to "return 0" from the !CONFIG_ARM_TEGRA_CPUFREQ case; the > whole point is to isolate callers from having to care whether > CONFIG_ARM_TEGRA_CPUFREQ is enabled, and making the function act like it > worked OK is part of that isolation. > OK thanks.
| |