Messages in this thread | | | From | Jingoo Han <> | Subject | Re: [PATCH 4/6] regulator: gpio-regulator: use devm_regulator_register() | Date | Mon, 09 Dec 2013 11:01:24 +0900 |
| |
On Friday, December 06, 2013 9:09 PM, Mark Brown wrote: > On Fri, Dec 06, 2013 at 10:12:05AM +0100, Heiko Stübner wrote: > > > I'm not this firm in the core driver/device behaviour, but when looking at > > __device_release_driver I see that the remove callback runs before > > devres_release_all, which would effectively free the gpios before the > > regulator gets unregistered - is this racy with a regulator change at the same > > time? > > Yes, the rest of the driver really needs to be converted to devm_ at the > same time.
The gpios is requested by gpio_request_array(). However, devm_gpio_request_array() is not supported yet, so the rest of the driver cannot be converted to devm_.
Mark Brown, Please ignore this patch.
Best regards, Jingoo Han
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |