lkml.org 
[lkml]   [2013]   [Dec]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: Oddball Author from on commit for rcu tree
On Sun, Dec 8, 2013 at 5:32 PM, Luis R. Rodriguez
<mcgrof@do-not-panic.com> wrote:
> I see this commit on linux-next:
>
> commit 705e5a58432b56f9821d6884341575c02536661f
> Author: Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> Date: Thu Oct 10 11:08:33 2013 -0700
>
> rcu: Fix coccinelle warnings
>
> This commit fixes the following coccinelle warning:
>
> kernel/rcu/tree.c:712:9-10: WARNING: return of 0/1 in function
> 'rcu_lockdep_current_cpu_online' with return type bool
>
> Return statements in functions returning bool should use
> true/false instead of 1/0.
> Generated by: coccinelle/misc/boolreturn.cocci
>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
>
> diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
> index 3049950..f8c0299 100644
> --- a/kernel/rcu/tree.c
> +++ b/kernel/rcu/tree.c
> @@ -725,7 +725,7 @@ bool rcu_lockdep_current_cpu_online(void)
> bool ret;
>
> if (in_nmi())
> - return 1;
> + return true;
> preempt_disable();
> rdp = this_cpu_ptr(&rcu_sched_data);
> rnp = rdp->mynode;
>
>
> Although I'm enjoying the usage of the Generated by tag thing, the
> From of that patch had the Signed-off-by tag, not sure how that
> happened but if its going to happen more better we catch it now. Also
> not sure if that will trigger a flag to Greg and Corbet's stat scripts
> but just in case Cc'd.

Doh, too late:

mcgrof@cerro ~/linux-next (git::master)$ git log --pretty="%an" | grep Signed
Signed-off-by: Fengguang Wu
Signed-off-by: Sony Chacko
Signed-off-by: Sony Chacko
Signed-off-by: Jan Kara
Signed-off-by: Darren Hart
Signed-off-by: Darren Hart
Signed-off-by: Darren Hart
Signed-off-by: Wu Fengguang
Signed-off-by: Peter Stokes
Signed-off by Yi Yang
Signed-off-by@vergenet.net":Simon

Luis


\
 
 \ /
  Last update: 2013-12-08 18:01    [W:0.042 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site