lkml.org 
[lkml]   [2013]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.12 01/83] net: mv643xx_eth: Add missing phy_addr_set in DT mode
    Date
    3.12-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>

    Commit cc9d4598 'net: mv643xx_eth: use of_phy_connect if phy_node
    present' made the call to phy_scan optional, if the DT has a link to
    the phy node.

    However phy_scan has the side effect of calling phy_addr_set, which
    writes the phy MDIO address to the ethernet controller. If phy_addr_set
    is not called, and the bootloader has not set the correct address then
    the driver will fail to function.

    Tested on Kirkwood.

    Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
    Acked-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
    Tested-by: Arnaud Ebalard <arno@natisbad.org>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/marvell/mv643xx_eth.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/net/ethernet/marvell/mv643xx_eth.c
    +++ b/drivers/net/ethernet/marvell/mv643xx_eth.c
    @@ -2890,6 +2890,7 @@ static int mv643xx_eth_probe(struct plat
    PHY_INTERFACE_MODE_GMII);
    if (!mp->phy)
    err = -ENODEV;
    + phy_addr_set(mp, mp->phy->addr);
    } else if (pd->phy_addr != MV643XX_ETH_PHY_NONE) {
    mp->phy = phy_scan(mp, pd->phy_addr);




    \
     
     \ /
      Last update: 2013-12-06 23:01    [W:3.775 / U:0.832 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site