Messages in this thread | | | Date | Fri, 6 Dec 2013 11:25:03 -0500 | From | Tejun Heo <> | Subject | Re: [PATCH cgroup/for-3.13-fixes] cgroup: fix oops in cgroup init failure path |
| |
On Fri, Dec 06, 2013 at 11:13:12AM -0500, Tejun Heo wrote: > > Second, it's not clear to me why we need the CSS_ONLINE flag at all if > > we never assign css's that we fail to online to a cgroup. AFAIU we will > > never see such css's, because in all places we call offline_css(), > > namely cgroup_destroy_locked() (via kill_css()) and > > cgroup_unload_subsys(), we use cgroup_css() which will return NULL for them. > > The whole thing is in flux and will look very different in near > future. I actually had patches queued which deal with the issue you > spotted but they are being blocked on other changes ATM. So, yeah, > there are some spurious stuff now.
LOL, I found the patch. It was posted and acked I just forgot to apply the whole series. I'm a moron.
http://permalink.gmane.org/gmane.linux.kernel.containers/26804
This should do it, right? I'll update the patch description and repost the series.
Thanks!
-- tejun
| |