Messages in this thread | | | From | Kamil Debski <> | Subject | RE: [PATCH v4 5/9] usb: s3c-hsotg: Use the new Exynos USB phy driver with the generic phy framework | Date | Fri, 06 Dec 2013 17:29:21 +0100 |
| |
Hi,
> From: Matt Porter [mailto:matt.porter@linaro.org] > Sent: Friday, December 06, 2013 4:01 PM > > On Fri, Dec 06, 2013 at 04:41:51PM +0530, Kishon Vijay Abraham I wrote: > > Hi, > > > > On Thursday 05 December 2013 05:59 PM, Kamil Debski wrote: > > > Change the used phy driver to the new Exynos USB phy driver that > > > uses the generic phy framework. > > > > > > Signed-off-by: Kamil Debski <k.debski@samsung.com> > > > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com> > > > --- > > > .../devicetree/bindings/usb/samsung-hsotg.txt | 4 ++++ > > > drivers/usb/gadget/s3c-hsotg.c | 11 ++++++-- > --- > > > 2 files changed, 10 insertions(+), 5 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/usb/samsung- > hsotg.txt > > > b/Documentation/devicetree/bindings/usb/samsung-hsotg.txt > > > index b83d428..9340d06 100644 > > > --- a/Documentation/devicetree/bindings/usb/samsung-hsotg.txt > > > +++ b/Documentation/devicetree/bindings/usb/samsung-hsotg.txt > > > @@ -24,6 +24,8 @@ Required properties: > > > - first entry: must be "otg" > > > - vusb_d-supply: phandle to voltage regulator of digital section, > > > - vusb_a-supply: phandle to voltage regulator of analog section. > > > +- phys: from general PHY binding: phandle to the PHY device > > > +- phy-names: from general PHY binding: should be "usb2-phy" > > > > are you sure it's usb2-phy. The example below seems to have a > different value. > > I requested this be changed to usb2-phy, looks like he just missed the > update to the example.
This is true. I missed the change in the example part of the file.
> > > > > > > > > Example > > > ----- > > > @@ -36,5 +38,7 @@ Example > > > clock-names = "otg"; > > > vusb_d-supply = <&vusb_reg>; > > > vusb_a-supply = <&vusbdac_reg>; > > > + phys = <&usb2phy 0>; > > > + phy-names = "device"; > > > };
Best wishes, -- Kamil Debski Samsung R&D Institute Poland
| |