Messages in this thread |  | | Date | Fri, 6 Dec 2013 15:34:36 +0000 | From | Lee Jones <> | Subject | Re: [PATCH v5 1/3] mfd: tps6586x: add version detection |
| |
On Fri, 06 Dec 2013, Thierry Reding wrote:
> On Fri, Dec 06, 2013 at 01:51:45PM +0100, Stefan Agner wrote: > > Use the VERSIONCRC to determine the exact device version. According to > > the datasheet this register can be used as device identifier. The > > identification is needed since some tps6586x regulators use a different > > voltage table. > > > > Signed-off-by: Stefan Agner <stefan@agner.ch> > > --- > > Changes since v4: > > - Use variable named version instead of ret > > > > Changes since v2: > > - Avoid moving devm_kzalloc > > --- > > drivers/mfd/tps6586x.c | 50 +++++++++++++++++++++++++++++++++++++------- > > include/linux/mfd/tps6586x.h | 7 +++++++ > > 2 files changed, 49 insertions(+), 8 deletions(-) > > I think I also already gave my Reviewed-by on both this and 2/3, neither > of which changed significantly enough to warrant that to be dropped. In > general it's fine to keep Reviewed-by and Acked-by as long as you're > only changing minor things.
Don't worry Thierry, I'll ensure they are applied.
-- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |