lkml.org 
[lkml]   [2013]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.11 048/272] gpio: rcar: NULL dereference on error in probe()
    Date
    3.11.10.1 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Dan Carpenter <dan.carpenter@oracle.com>

    commit 0c8aab8e65e450f2bfea494c1b6a86ded653f88c upstream.

    It's not obvious from the label name but "err1" tries to release
    "p->irq_domain" which leads to a NULL dereference.

    Fixes: 119f5e448d32 ('gpio: Renesas R-Car GPIO driver V3')

    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Acked-by: Magnus Damm <damm@opensource.se>
    Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
    Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
    ---
    drivers/gpio/gpio-rcar.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/gpio/gpio-rcar.c b/drivers/gpio/gpio-rcar.c
    index e8198dd..e73f437 100644
    --- a/drivers/gpio/gpio-rcar.c
    +++ b/drivers/gpio/gpio-rcar.c
    @@ -381,7 +381,7 @@ static int gpio_rcar_probe(struct platform_device *pdev)
    if (!p->irq_domain) {
    ret = -ENXIO;
    dev_err(&pdev->dev, "cannot initialize irq domain\n");
    - goto err1;
    + goto err0;
    }

    if (devm_request_irq(&pdev->dev, irq->start,
    --
    1.8.3.2


    \
     
     \ /
      Last update: 2013-12-06 15:41    [W:4.051 / U:0.424 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site