Messages in this thread | | | Date | Fri, 6 Dec 2013 10:11:12 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH] staging: silicom: fix 'return is not a function, parentheses are not required' in bpctl_mod.c |
| |
On Thu, Dec 05, 2013 at 03:29:22PM -0800, Joe Perches wrote: > On Fri, 2013-12-06 at 02:21 +0300, Dan Carpenter wrote: > > On Thu, Dec 05, 2013 at 03:09:15PM -0800, Joe Perches wrote: > > > On Fri, 2013-12-06 at 01:50 +0300, Dan Carpenter wrote: > > > > On Thu, Dec 05, 2013 at 10:23:53PM +0100, Will Tange wrote: > > Ah. > > Then maybe use a single ?: or a ! instead > > return ret ? 0 : 1; > or > return !ret; >
You still have to handle the negative.
if (ret < 0) return ret;
return !ret;
regards, dan carpenter
| |