lkml.org 
[lkml]   [2013]   [Dec]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.11 231/272] ALSA: 6fire: Fix probe of multiple cards
    Date
    3.11.10.1 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Takashi Iwai <tiwai@suse.de>

    commit 9b389a8a022110b4bc055a19b888283544d9eba6 upstream.

    The probe code of snd-usb-6fire driver overrides the devices[] pointer
    wrongly without checking whether it's already occupied or not. This
    would screw up the device disconnection later.

    Spotted by coverity CID 141423.

    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
    ---
    sound/usb/6fire/chip.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/sound/usb/6fire/chip.c b/sound/usb/6fire/chip.c
    index c39c779..66edc4a 100644
    --- a/sound/usb/6fire/chip.c
    +++ b/sound/usb/6fire/chip.c
    @@ -101,7 +101,7 @@ static int usb6fire_chip_probe(struct usb_interface *intf,
    usb_set_intfdata(intf, chips[i]);
    mutex_unlock(&register_mutex);
    return 0;
    - } else if (regidx < 0)
    + } else if (!devices[i] && regidx < 0)
    regidx = i;
    }
    if (regidx < 0) {
    --
    1.8.3.2


    \
     
     \ /
      Last update: 2013-12-06 15:01    [W:4.028 / U:2.620 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site