Messages in this thread | | | Date | Fri, 6 Dec 2013 20:46:43 +0900 | Subject | Re: [PATCH 3/4] mm/migrate: remove putback_lru_pages, fix comment on putback_movable_pages | From | Joonsoo Kim <> |
| |
2013/12/6 Zhang Yanfei <zhangyanfei@cn.fujitsu.com>: > Hello > > On 12/06/2013 04:41 PM, Joonsoo Kim wrote: >> Some part of putback_lru_pages() and putback_movable_pages() is >> duplicated, so it could confuse us what we should use. >> We can remove putback_lru_pages() since it is not really needed now. >> This makes us undestand and maintain the code more easily. >> >> And comment on putback_movable_pages() is stale now, so fix it. >> >> Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com> >> >> diff --git a/include/linux/migrate.h b/include/linux/migrate.h >> index f5096b5..7782b74 100644 >> --- a/include/linux/migrate.h >> +++ b/include/linux/migrate.h >> @@ -35,7 +35,6 @@ enum migrate_reason { >> >> #ifdef CONFIG_MIGRATION >> >> -extern void putback_lru_pages(struct list_head *l); >> extern void putback_movable_pages(struct list_head *l); >> extern int migrate_page(struct address_space *, >> struct page *, struct page *, enum migrate_mode); >> @@ -59,7 +58,6 @@ extern int migrate_page_move_mapping(struct address_space *mapping, >> #else >> >> static inline void putback_lru_pages(struct list_head *l) {} > > If you want to remove the function, this should be removed, right?
Hello, Zhang.
Oop... It's my mistake. I will send v2. Thanks for finding this.
Thanks.
| |