lkml.org 
[lkml]   [2013]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v8] gpio: add a driver for the Synopsys DesignWare APB GPIO block
From
On Thu, Dec 5, 2013 at 4:53 PM, delicious quinoa
<delicious.quinoa@gmail.com> wrote:
> On Thu, Dec 5, 2013 at 10:54 AM, Jamie Iles <jamie@jamieiles.com> wrote:
>> Hi Alan,
>>
>> One minor comment below, otherwise looks great!
>>
>> Signed-off-by: Jamie Iles <jamie@jamieiles.com>
>>
>> Thanks,
>>
>> Jamie
>>
>> On Tue, Dec 03, 2013 at 10:41:16AM -0600, Alan Tull wrote:
>>> diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c
>>> new file mode 100644
>>> index 0000000..e6dc61f
>>> --- /dev/null
>>> +++ b/drivers/gpio/gpio-dwapb.c
>> ...
>>> +static unsigned int dwapb_gpio_nr_ports(struct device_node *of_node)
>>> +{
>>> + unsigned int nr_ports = 0;
>>> + struct device_node *np;
>>> +
>>> + for_each_child_of_node(of_node, np)
>>> + ++nr_ports;
>>> +
>>> + return nr_ports;
>>> +}
>>
>> I notice that we now have of_get_child_count() which didn't exist when I
>> first wrote the driver, we could use that now.
>
> Thanks Jamie.
>
> I'll include that in v8. I'll post that within a few days.
>
> Alan

er, I mean v9.

Alan


\
 
 \ /
  Last update: 2013-12-06 00:21    [W:1.132 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site