lkml.org 
[lkml]   [2013]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.5 28/90] x86/microcode/amd: Tone down printk(), don't treat a missing firmware file as an error
    Date
    3.5.7.27 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Thomas Renninger <trenn@suse.de>

    commit 11f918d3e2d3861b6931e97b3aa778e4984935aa upstream.

    Do it the same way as done in microcode_intel.c: use pr_debug()
    for missing firmware files.

    There seem to be CPUs out there for which no microcode update
    has been submitted to kernel-firmware repo yet resulting in
    scary sounding error messages in dmesg:

    microcode: failed to load file amd-ucode/microcode_amd_fam16h.bin

    Signed-off-by: Thomas Renninger <trenn@suse.de>
    Acked-by: Borislav Petkov <bp@suse.de>
    Link: http://lkml.kernel.org/r/1384274383-43510-1-git-send-email-trenn@suse.de
    Signed-off-by: Ingo Molnar <mingo@kernel.org>
    Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
    ---
    arch/x86/kernel/microcode_amd.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/arch/x86/kernel/microcode_amd.c b/arch/x86/kernel/microcode_amd.c
    index 5d8cf0d..b316ffe 100644
    --- a/arch/x86/kernel/microcode_amd.c
    +++ b/arch/x86/kernel/microcode_amd.c
    @@ -338,7 +338,7 @@ static enum ucode_state request_microcode_amd(int cpu, struct device *device)
    snprintf(fw_name, sizeof(fw_name), "amd-ucode/microcode_amd_fam%.2xh.bin", c->x86);

    if (request_firmware(&fw, (const char *)fw_name, device)) {
    - pr_err("failed to load file %s\n", fw_name);
    + pr_debug("failed to load file %s\n", fw_name);
    goto out;
    }

    --
    1.8.3.2


    \
     
     \ /
      Last update: 2013-12-05 20:01    [W:4.177 / U:0.768 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site