Messages in this thread | | | Date | Thu, 5 Dec 2013 16:54:39 +0000 | From | Jamie Iles <> | Subject | Re: [PATCH v8] gpio: add a driver for the Synopsys DesignWare APB GPIO block |
| |
Hi Alan,
One minor comment below, otherwise looks great!
Signed-off-by: Jamie Iles <jamie@jamieiles.com>
Thanks,
Jamie
On Tue, Dec 03, 2013 at 10:41:16AM -0600, Alan Tull wrote: > diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c > new file mode 100644 > index 0000000..e6dc61f > --- /dev/null > +++ b/drivers/gpio/gpio-dwapb.c ... > +static unsigned int dwapb_gpio_nr_ports(struct device_node *of_node) > +{ > + unsigned int nr_ports = 0; > + struct device_node *np; > + > + for_each_child_of_node(of_node, np) > + ++nr_ports; > + > + return nr_ports; > +}
I notice that we now have of_get_child_count() which didn't exist when I first wrote the driver, we could use that now.
| |