lkml.org 
[lkml]   [2013]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/2] usb: chipidea: fix mistake in device tree binding of nspire-usb to use vendor name 'lsi' instead of SoC name 'zevio'
From
Date
Hi,

On 05/12/2013, at 12:44 AM, Peter Chen <Peter.Chen@freescale.com> wrote:

>
> lsi is vendor name, what are zevio and nspire?
> Usually, the compatible string should be "vendor_name,soc_name-module_name"
>

Because this port uses documentation from reverse engineering, it's difficult to work out what is SoC specific and what is device specific. The SoC is Zevio but the driver is written for the TI-Nspire.

If it's usually "vendor_name,soc_name-module_name", I'll fix up this patch with zevio instead of nspire (and it'll be more consistent with the other drivers).

>> - reg: Should contain registers location and length
>> - interrupts: Should contain controller interrupt
>>
>> @@ -11,7 +11,7 @@ Recommended properies:
>> Examples:
>> usb0: usb@B0000000 {
>> reg = <0xB0000000 0x1000>;
>> - compatible = "zevio,nspire-usb";
>> + compatible = "lsi,nspire-usb";
>> interrupts = <8>;
>> vbus-supply = <&vbus_reg>;
>> };
>> diff --git a/drivers/usb/chipidea/ci_hdrc_nspire.c b/drivers/usb/chipidea/ci_hdrc_nspire.c
>> index 517ce41..c5c2dde 100644
>> --- a/drivers/usb/chipidea/ci_hdrc_nspire.c
>> +++ b/drivers/usb/chipidea/ci_hdrc_nspire.c
>> @@ -52,7 +52,7 @@ static int ci_hdrc_nspire_remove(struct platform_device *pdev)
>> }
>>
>> static const struct of_device_id ci_hdrc_nspire_dt_ids[] = {
>> - { .compatible = "zevio,nspire-usb", },
>> + { .compatible = "lsi,nspire-usb", },
>> { /* sentinel */ }
>> };
>>
>> --
>> 1.7.10.4
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>
> --
>
> Best Regards,
> Peter Chen
>

Cheers,
Daniel Tang

\
 
 \ /
  Last update: 2013-12-05 07:21    [W:0.104 / U:0.104 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site