lkml.org 
[lkml]   [2013]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 28/39] staging: remove DEFINE_PCI_DEVICE_TABLE macro
On Thu, Dec 05, 2013 at 05:06:33PM +0800, ZHAO Gang wrote:
> On Tue, Dec 3, 2013 at 7:26 AM, Jingoo Han <jg1.han@samsung.com> wrote:
> > Don't use DEFINE_PCI_DEVICE_TABLE macro, because this macro
> > is not preferred.
> >
> > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> >
>
> I think you misunderstood the checkpatch.pl warning, it tells you what
> to do, not what not to do.
>
> WARNING: Use DEFINE_PCI_DEVICE_TABLE for struct pci_device_id
>
> This means use DEFINE_PCI_DEVICE_TABLE to replace struct
> pci_device_id, not reverse.

No, checkpatch is wrong, and is being fixed, this patch is correct.


\
 
 \ /
  Last update: 2013-12-05 17:01    [W:0.113 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site