lkml.org 
[lkml]   [2013]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 2/5] fat: add fat_fallocate operation
From
2013/12/1, OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>:
> Namjae Jeon <linkinjeon@gmail.com> writes:
>
>> + err = fat_get_cluster(inode, FAT_ENT_EOF,
>> + &fclus, &dclus);
>> + if (err < 0) {
>> + fat_msg(sb, KERN_ERR,
>> + "fat_fallocate(): fat_get_cluster() error");
>> + goto error;
>> + }
>> + free_bytes = ((fclus + 1) << sbi->cluster_bits) -
>> + inode->i_size;
>
> What is wrong if we just used ->mmu_private here, instead of fclus?
It is not wrong. We can make it more simpler if we use mmu_private here.
I will change it.
Thanks for review.
> --
> OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
>


\
 
 \ /
  Last update: 2013-12-05 15:41    [W:0.248 / U:0.440 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site