Messages in this thread |  | | Date | Thu, 5 Dec 2013 13:35:36 +0000 | From | Mel Gorman <> | Subject | Re: [PATCH 03/15] mm: thp: give transparent hugepage code a separate copy_page |
| |
On Wed, Dec 04, 2013 at 10:59:18AM -0600, Alex Thorlton wrote: > > -void copy_huge_page(struct page *dst, struct page *src) > > -{ > > - int i; > > - struct hstate *h = page_hstate(src); > > - > > - if (unlikely(pages_per_huge_page(h) > MAX_ORDER_NR_PAGES)) { > > With CONFIG_HUGETLB_PAGE=n, the kernel fails to build, throwing this > error: > > mm/migrate.c: In function ???copy_huge_page???: > mm/migrate.c:473: error: implicit declaration of function ???page_hstate??? > > I got it to build by sticking the following into hugetlb.h: > > diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h > index 4694afc..fd76912 100644 > --- a/include/linux/hugetlb.h > +++ b/include/linux/hugetlb.h > @@ -403,6 +403,7 @@ struct hstate {}; > #define hstate_sizelog(s) NULL > #define hstate_vma(v) NULL > #define hstate_inode(i) NULL > +#define page_hstate(p) NULL > #define huge_page_size(h) PAGE_SIZE > #define huge_page_mask(h) PAGE_MASK > #define vma_kernel_pagesize(v) PAGE_SIZE > > I figure that the #define I stuck in isn't actually solving the real > problem, but it got things working again. >
It's based on an upstream patch so I'll check if the problem is there as well and backport accordingly. This patch to unblock yourself is fine for now.
Thanks.
-- Mel Gorman SUSE Labs
|  |