lkml.org 
[lkml]   [2013]   [Dec]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] x86/apic: Justification for disabling IO APIC before Local APIC
Date
> From: Ingo Molnar [mailto:mingo.kernel.org@gmail.com] On Behalf Of Ingo
> Molnar
> Sent: Thursday, December 05, 2013 12:55 AM
>
>
> * Fenghua Yu <fenghua.yu@intel.com> wrote:
>
> > From: Fenghua Yu <fenghua.yu@intel.com>
> >
> > Since erratum AVR31 in "Intel Atom Processor C2000 Product Family
> > Specification Update" is published, I add a justification comment for
> > disabling IO APIC before Local APIC (commit 522e6646).
> >
>
> Looks good to me, except that patch titles should start with verbs,
> i.e. something like:
>
> x86/apic/doc: Add justification for disabling IO APIC before Local
> APIC
>
> Which makes for a much more fluid reading of shortlogs etc.
>
> Unless you sentences without verbs.
> ^-------------------------------------------like
>
> ;-)
>
> Thanks,
>
> Ingo

Thank you very much for your comment, Ingo.

-Fenghua


\
 
 \ /
  Last update: 2013-12-05 15:01    [W:0.141 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site