Messages in this thread | | | From | "Yu, Fenghua" <> | Subject | RE: [PATCH] x86/apic: Justification for disabling IO APIC before Local APIC | Date | Thu, 5 Dec 2013 13:27:05 +0000 |
| |
> From: Ingo Molnar [mailto:mingo.kernel.org@gmail.com] On Behalf Of Ingo > Molnar > Sent: Thursday, December 05, 2013 12:55 AM > > > * Fenghua Yu <fenghua.yu@intel.com> wrote: > > > From: Fenghua Yu <fenghua.yu@intel.com> > > > > Since erratum AVR31 in "Intel Atom Processor C2000 Product Family > > Specification Update" is published, I add a justification comment for > > disabling IO APIC before Local APIC (commit 522e6646). > > > > Looks good to me, except that patch titles should start with verbs, > i.e. something like: > > x86/apic/doc: Add justification for disabling IO APIC before Local > APIC > > Which makes for a much more fluid reading of shortlogs etc. > > Unless you sentences without verbs. > ^-------------------------------------------like > > ;-) > > Thanks, > > Ingo
Thank you very much for your comment, Ingo.
-Fenghua
| |