Messages in this thread | | | Date | Thu, 5 Dec 2013 11:35:31 +0000 | From | Mark Brown <> | Subject | Re: [PATCH] regulator: gpio: Don't require a regulator-type property |
| |
On Thu, Dec 05, 2013 at 01:44:42AM +0100, Laurent Pinchart wrote: > On Thursday 05 December 2013 00:31:55 Mark Brown wrote:
> > + if (ret >= 0) { > > + if (!strncmp("voltage", regtype, 7)) > > + config->type = REGULATOR_VOLTAGE; > > + else if (!strncmp("current", regtype, 7)) > > + config->type = REGULATOR_CURRENT;
> Should we warn or error in case of an unsupported value ?
That's sensible, yes - this was just a straight change to make the property optional. Given that we've always accepted anything a warning seems more appropriate otherwise we might break existing DTs with typos or something. [unhandled content-type:application/pgp-signature] | |