Messages in this thread |  | | Date | Wed, 04 Dec 2013 09:40:46 +0100 | From | Stefan Agner <> | Subject | Re: [PATCH v4 1/3] mfd: tps6586x: add version detection |
| |
Am 2013-12-04 09:10, schrieb Lee Jones: >> +int tps6586x_get_version(struct device *dev) >> +{ >> + struct tps6586x *tps6586x = dev_get_drvdata(dev); >> + >> + return tps6586x->version; >> +} >> +EXPORT_SYMBOL_GPL(tps6586x_get_version); > > I thought Mark suggested that this routine was converted to a 'static > inline' and moved into the header? Did you not think this was a good > idea? As I pointed out in the comment above, the struct tps6586x is in the C file, so I would need to move that too. That's why I did not made that change in the end. What do you think, should I still move (and move the struct too?)
|  |