lkml.org 
[lkml]   [2013]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [RFC PATCH tip 0/5] tracing filters with BPF
    From
    > On Tue, Dec 3, 2013 at 4:01 PM, Andi Kleen <andi@firstfloor.org> wrote:
    >>
    >> Can you do some performance comparison compared to e.g. ktap?
    >> How much faster is it?

    Did simple ktap test with 1M alloc_skb/kfree_skb toy test from earlier email:
    trace skb:kfree_skb {
    if (arg2 == 0x100) {
    printf("%x %x\n", arg1, arg2)
    }
    }
    1M skb alloc/free 350315 (usecs)

    baseline without any tracing:
    1M skb alloc/free 145400 (usecs)

    then equivalent bpf test:
    void filter(struct bpf_context *ctx)
    {
    void *loc = (void *)ctx->regs.dx;
    if (loc == 0x100) {
    struct sk_buff *skb = (struct sk_buff *)ctx->regs.si;
    char fmt[] = "skb %p loc %p\n";
    bpf_trace_printk(fmt, sizeof(fmt), (long)skb, (long)loc, 0);
    }
    }
    1M skb alloc/free 183214 (usecs)

    so with one 'if' condition the difference ktap vs bpf is 350-145 vs 183-145

    obviously ktap is an interpreter, so it's not really fair.

    To make it really unfair I did:
    trace skb:kfree_skb {
    if (arg2 == 0x100 || arg2 == 0x200 || arg2 == 0x300 || arg2 == 0x400 ||
    arg2 == 0x500 || arg2 == 0x600 || arg2 == 0x700 || arg2 == 0x800 ||
    arg2 == 0x900 || arg2 == 0x1000) {
    printf("%x %x\n", arg1, arg2)
    }
    }
    1M skb alloc/free 484280 (usecs)

    and corresponding bpf:
    void filter(struct bpf_context *ctx)
    {
    void *loc = (void *)ctx->regs.dx;
    if (loc == 0x100 || loc == 0x200 || loc == 0x300 || loc == 0x400 ||
    loc == 0x500 || loc == 0x600 || loc == 0x700 || loc == 0x800 ||
    loc == 0x900 || loc == 0x1000) {
    struct sk_buff *skb = (struct sk_buff *)ctx->regs.si;
    char fmt[] = "skb %p loc %p\n";
    bpf_trace_printk(fmt, sizeof(fmt), (long)skb, (long)loc, 0);
    }
    }
    1M skb alloc/free 185660 (usecs)

    the difference is bigger now: 484-145 vs 185-145

    9 extra 'if' conditions for bpf is almost nothing, since they
    translate into 18 new x86 instructions after JITing, but for
    interpreter it's obviously costly.

    Why 0x100 instead of 0x1? To make sure that compiler doesn't optimize
    them into < >
    Otherwise it's really really unfair.

    ktap is a nice tool. Great job Jovi!
    I noticed that it doesn't always clear created kprobes after run and I
    see a bunch of .../tracing/events/ktap_kprobes_xxx, but that's a minor
    thing.

    Thanks
    Alexei


    \
     
     \ /
      Last update: 2013-12-05 06:01    [W:4.330 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site