Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH] virtio_balloon: update_balloon_size(): update correct field | Date | Thu, 05 Dec 2013 13:04:36 +1030 |
| |
Luiz Capitulino <lcapitulino@redhat.com> writes: > According to the virtio spec, the device configuration field > that should be updated after an inflation or deflation > operation is the 'actual' field, not the 'num_pages' one. > > Commit 855e0c5288177bcb193f6f6316952d2490478e1c swapped them > in update_balloon_size(). Fix it. > > Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
Damn, exactly right. Good catch.
Applied, Rusty.
> drivers/virtio/virtio_balloon.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c > index c444654..5c4a95b 100644 > --- a/drivers/virtio/virtio_balloon.c > +++ b/drivers/virtio/virtio_balloon.c > @@ -285,7 +285,7 @@ static void update_balloon_size(struct virtio_balloon *vb) > { > __le32 actual = cpu_to_le32(vb->num_pages); > > - virtio_cwrite(vb->vdev, struct virtio_balloon_config, num_pages, > + virtio_cwrite(vb->vdev, struct virtio_balloon_config, actual, > &actual); > } > > -- > 1.8.1.4
| |