Messages in this thread |  | | Date | Wed, 4 Dec 2013 09:20:24 +0100 | From | Thierry Reding <> | Subject | Re: [PATCH V2 1/2] ARM: tegra: Add header file for pinctrl constants |
| |
On Tue, Dec 03, 2013 at 06:46:06PM +0530, Laxman Dewangan wrote: > This new header file defines pincontrol constants for Tegra to > use from Tegra's DTS file for pincontrol properties option. > > Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com> > --- > Changes from V1: > - Get rid of lots of macro and converge it to TEGRA_PIN_ENABLE/DISABLE. > - Change macro name for PULL UP/DOWN/NONE. > > include/dt-bindings/pinctrl/pinctrl-tegra.h | 40 +++++++++++++++++++++++++++ > 1 files changed, 40 insertions(+), 0 deletions(-) > create mode 100644 include/dt-bindings/pinctrl/pinctrl-tegra.h
I like this a lot. One minor nit below.
> diff --git a/include/dt-bindings/pinctrl/pinctrl-tegra.h b/include/dt-bindings/pinctrl/pinctrl-tegra.h > new file mode 100644 > index 0000000..e5f02f8 > --- /dev/null > +++ b/include/dt-bindings/pinctrl/pinctrl-tegra.h > @@ -0,0 +1,40 @@ > +/* > + * This header provides constants for TEGRA pinctrl bindings.
"TEGRA" -> "Tegra"
Other than that:
Reviewed-by: Thierry Reding <treding@nvidia.com> [unhandled content-type:application/pgp-signature] |  |