[lkml]   [2013]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: 2e685cad5790 build warning
[ botched linux-kernel address in the first try ]

On Wed, Dec 04, 2013 at 05:29:43PM -0500, Johannes Weiner wrote:
> Hi Eric,
> commit 2e685cad57906e19add7189b5ff49dfb6aaa21d3
> Author: Eric W. Biederman <>
> Date: Sat Oct 19 16:26:19 2013 -0700
> tcp_memcontrol: Kill struct tcp_memcontrol
> Replace the pointers in struct cg_proto with actual data fields and kill
> struct tcp_memcontrol as it is not fully redundant.
> This removes a confusing, unnecessary layer of abstraction.
> Signed-off-by: "Eric W. Biederman" <>
> Signed-off-by: David S. Miller <>
> triggers a build warning because it removed the only reference to a
> function but not the function itself:
> linux/net/ipv4/tcp_memcontrol.c:9:13: warning: ‘memcg_tcp_enter_memory_pressure’ defined but not used [-Wunused-function]
> static void memcg_tcp_enter_memory_pressure(struct sock *sk)
> I can not see from the changelog why this function is no longer used,
> or who is supposed to now set cg_proto->memory_pressure which you
> still initialize etc. Either way, the current state does not seem to
> make much sense. The author would be the best person to double check
> such changes, but he wasn't copied on your patch, so I copied him now.
> Apologies if this has been brought up before, I could not find any
> reference on LKML of either this patch or a report of this warning.
> Thanks!
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
More majordomo info at
Please read the FAQ at

 \ /
  Last update: 2013-12-05 00:01    [W:0.022 / U:3.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site