lkml.org 
[lkml]   [2013]   [Dec]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] Staging: speakup: synth.c: removed a space
From
Date
On Wed, 2013-12-04 at 10:38 +0300, Dan Carpenter wrote:
> On Wed, Dec 04, 2013 at 06:35:15AM +0200, Aldo Iljazi wrote:
> > Samuel Thibault wrote:
> >
> > > Err, I'd rather make it really visible that the for loop doesn't have
> > > its first statement?
> >
> > Wouldn't it be better if you add a comment there? So it would follow the
> > coding style?
>
> No. Adding obvious comments is more annoying than the space.
>
> This seems like a small bug in checkpatch.pl. Joe, the problem is this
> code:
>
> for ( ; x; x++) {
>
> It's complaining about the space character before the semicolon.

Shrug. checkpatch isn't and can't be perfect.

I think it's for things like

for (;;)

and that's better than

for ( ; ; )
or
for ( ;; )
or
for ( ;;)




\
 
 \ /
  Last update: 2013-12-04 09:01    [W:0.631 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site