Messages in this thread |  | | Date | Wed, 4 Dec 2013 13:23:52 -0600 | Subject | Re: [PATCH v2] OF: base: match each node compatible against all given matches first | From | Rob Herring <> |
| |
On Tue, Dec 3, 2013 at 7:52 AM, Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> wrote: > Currently, of_match_node compares each given match against all node's > compatible strings with of_device_is_compatible. > > To achieve multiple compatible strings per node with ordering from > specific to generic, this requires given matches to be ordered from > specific to generic. For most of the drivers this is not true and also > an alphabetical ordering is more sane there. > > Therefore, this patch modifies of_match_node to match each of the node's > compatible strings against all given matches first, before checking the > next compatible string. This implies that node's compatibles are ordered > from specific to generic while given matches can be in any order. > > Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> > --- > Changelog: > v1->v2: > - Allow checks against nodes with no compatible (Reported by Rob Herring) > - Add some comments > > Cc: Grant Likely <grant.likely@linaro.org> > Cc: Rob Herring <rob.herring@calxeda.com> > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> > Cc: Russell King <linux@arm.linux.org.uk> > Cc: Thierry Reding <thierry.reding@gmail.com> > Cc: Meelis Roos <mroos@linux.ee> > Cc: Marc Kleine-Budde <mkl@pengutronix.de> > Cc: Scott Wood <scottwood@freescale.com> > Cc: devicetree@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > --- > drivers/of/base.c | 53 +++++++++++++++++++++++++++++++++++++---------------- > 1 files changed, 37 insertions(+), 16 deletions(-)
Applied.
Rob
|  |