Messages in this thread | | | Date | Wed, 4 Dec 2013 19:39:33 +0100 | Subject | Re: [PATCH] perf/x86: fix bug in event constraint end marker macro | From | Stephane Eranian <> |
| |
Ingo,
Ok, I have asked Maria to clean the patch up add more comments and repost a new version of the patch. She will repost ASAP.
Thanks.
On Wed, Dec 4, 2013 at 10:03 AM, Ingo Molnar <mingo@kernel.org> wrote: > > * Stephane Eranian <eranian@google.com> wrote: > >> #define EVENT_CONSTRAINT_END \ >> - EVENT_CONSTRAINT(0, 0, 0) >> + { .idxmsk64 = 0, \ >> + .code = 0, \ >> + .cmask = 0, \ >> + .weight = -1, \ >> + .overlap = 0, \ >> + .flags = 0, \ >> +} > > A nit, simply writing: > > #define EVENT_CONSTRAINT_END { .weight = -1, } > > ... should be enough as initialization to zero is guaranteed for the > other fields. > > Thanks, > > Ingo
| |