Messages in this thread | | | Date | Wed, 4 Dec 2013 09:07:03 -0800 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH 0/3] ARM Coresight: Enhance ETM tracing control |
| |
On Wed, Dec 04, 2013 at 11:52:34AM -0500, Adrien Vergé wrote: > Hi all, > > First, please excuse me for these misformatted patches that my email > client messed up. Next time I will use git send-email. The 3 patches > can be found on > http://git.dorsal.polymtl.ca/~averge?p=linux.git;a=shortlog;h=refs/heads/etm_with_addr_and_pid > > Greg: you're right, sysfs is a questionable place for tracing/debug > code. Debugfs or /dev entries would be the right place.
Why would /dev be correct?
What's wrong with the existing tracing infrastructure that you need to create a new one?
> Though, the only support for ETM in Linux is there, and currently very > limited because tracing options such as address and pid are not > configurable. The code I propose would make it usable, until someone > with time (and more experience than me ;)) moves it out from sysfs.
Your pid implementation is broken, see my other email about that :(
And again, what's wrong with the existing tracing functionalty that is processor agnostic? Why can't we just delete this driver today and use the existing trace code?
thanks,
greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |