Messages in this thread |  | | Date | Wed, 4 Dec 2013 11:52:34 -0500 | Subject | Re: [PATCH 0/3] ARM Coresight: Enhance ETM tracing control | From | Adrien Vergé <> |
| |
Hi all,
First, please excuse me for these misformatted patches that my email client messed up. Next time I will use git send-email. The 3 patches can be found on http://git.dorsal.polymtl.ca/~averge?p=linux.git;a=shortlog;h=refs/heads/etm_with_addr_and_pid
Greg: you're right, sysfs is a questionable place for tracing/debug code. Debugfs or /dev entries would be the right place.
Though, the only support for ETM in Linux is there, and currently very limited because tracing options such as address and pid are not configurable. The code I propose would make it usable, until someone with time (and more experience than me ;)) moves it out from sysfs.
Thanks,
Adrien
2013/12/4 Greg Kroah-Hartman <gregkh@linuxfoundation.org>: > On Tue, Dec 03, 2013 at 11:39:21PM -0500, Adrien Vergé wrote: >> Usage of ETM tracing facility is currently very limited: user can >> only start/stop tracing. This set of patches enables management of >> address combinations and PIDs that trigger tracing. >> >> ETM management was done via sysfs entries (trace_info, >> trace_running...), this code adds trace_addrrange and trace_pid to >> let the user read/write custom values. > > I have lots to say about this from a sysfs point of view, but first, why > is it in sysfs at all? Shouldn't all of this be in debugfs? > > greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |